libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixonmars <...@git.apache.org>
Subject [GitHub] libcloud pull request #1086: Add missing test_requirement "requests_mock" to...
Date Thu, 20 Jul 2017 06:36:12 GMT
GitHub user felixonmars opened a pull request:

    https://github.com/apache/libcloud/pull/1086

    Add missing test_requirement "requests_mock" to setup.py

    ## Add missing test_requirement "requests_mock" to setup.py
    
    ### Description
    
    requests_mock is needed and defined in test_requirements.txt, but is missing from setup.py.
Let's keep them consistent.
    
    ### Status
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/felixonmars/libcloud patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1086.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1086
    
----
commit 6391dc6cab5dca529c94da313c8e27d50575ab08
Author: Felix Yan <felixonmars@archlinux.org>
Date:   2017-07-20T06:34:30Z

    Add missing test_requirement "requests_mock" to setup.py

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message