libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-875) Route 53 driver formats TXT records incorrectly
Date Sun, 20 Aug 2017 22:59:02 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134587#comment-16134587
] 

ASF GitHub Bot commented on LIBCLOUD-875:
-----------------------------------------

GitHub user tonybaloney opened a pull request:

    https://github.com/apache/libcloud/pull/1093

    LIBCLOUD-875 fix route 53 DNS quote encapsulation

    ## fix route 53 DNS quote encapsulation
    
    Amazon's API stipulates that SPF and TXT records have quotes http://docs.aws.amazon.com/Route53/latest/DeveloperGuide/ResourceRecordTypes.html#TXTFormat
    The driver does not have any special casing for these records. I assume that existing
users either:
    - Get an error - see https://github.com/twisted/txacme/issues/120
    - Add quotes before calling the methods, in which case this behaviour should be supported
    
    For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
    section of our documentation.
    
    ### Status
    
    - work in progress
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tonybaloney/libcloud route53_formatting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1093.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1093
    
----
commit b3b5086d19baa585af4987b0e32e7fdbe595ea5a
Author: Anthony Shaw <anthonyshaw@apache.org>
Date:   2017-08-20T22:55:16Z

    create tests to validate LIBCLOUD-875

----


> Route 53 driver formats TXT records incorrectly
> -----------------------------------------------
>
>                 Key: LIBCLOUD-875
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-875
>             Project: Libcloud
>          Issue Type: Bug
>          Components: DNS
>            Reporter: Tristan Seligmann
>
> Route 53 expects the values of TXT records to be wrapped in quotation marks ("value"),
but the driver does not add these for you.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message