libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LIBCLOUD-918) AzureNodeDriver's ex_create_public_ip method is missing the option to create a static public IP address
Date Thu, 17 Aug 2017 18:21:01 GMT

    [ https://issues.apache.org/jira/browse/LIBCLOUD-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130952#comment-16130952
] 

ASF GitHub Bot commented on LIBCLOUD-918:
-----------------------------------------

GitHub user aki-k opened a pull request:

    https://github.com/apache/libcloud/pull/1091

    [LIBCLOUD-918] Add an option to create a static public IP address.

    ### Title
    
    Add an option to create a static public IP address.
    
    ### Description
    
    Azure ARM driver's ex_create_public_ip only has the option to create a dynamic 
    public IP address. This change adds the option to create a static public IP address.
    
    https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-ip-addresses-overview-arm
    
    ### Status
    
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [X] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aki-k/libcloud LIBCLOUD-918_ex_create_public_ip

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1091.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1091
    
----
commit c1ee7b14b1956744392eeb576c540e8c638af030
Author: Aki Ketolainen <aki@siroic.com>
Date:   2017-08-17T18:06:32Z

    [LIBCLOUD-918] Add an option to create a static public IP address.

----


> AzureNodeDriver's ex_create_public_ip method is missing the option to create a static
public IP address
> -------------------------------------------------------------------------------------------------------
>
>                 Key: LIBCLOUD-918
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-918
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>    Affects Versions: 0.15.0
>         Environment: CentOS 6.8 (x86_64)
>            Reporter: Aki Ketolainen
>            Priority: Minor
>
> In AzureNodeDriver class, ex_create_public_ip method does not allow for creation of a
static public IP address. "publicIPAllocationMethod" is statically set to  "Dynamic" in the
"data" dictionary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message