libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (LIBCLOUD-930) EC2 create_node should supply tag data to RunInstances rather than tagging separately
Date Wed, 30 Aug 2017 20:49:00 GMT


ASF GitHub Bot commented on LIBCLOUD-930:

GitHub user ldipenti opened a pull request:

    Use TagSpecification parameter on EC2 create_node

    ## Take advantage of AWS EC2 tag-on-create feature
    ### Description
    This small patch changes the way EC2 compute nodes are tagged when created, by adding
the tags on the creation call instead of doing it immediately after. This avoids eventual
consistency issues that sometimes happen when an instance isn't created yet so it can't be
    For reference, the AWS docs are here:
    This PR would tackle a colleague of mine has reported some weeks ago:
    ### Status
    - done, ready for review
    ### Checklist (tick everything that applies)
    - [ ] [Code linting](
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](
    - [X] [ICLA](
(required for bigger changes) (I've just submitted it.)

You can merge this pull request into a Git repository by running:

    $ git pull apache-libcloud-2.2.0.dev1

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1100


> EC2 create_node should supply tag data to RunInstances rather than tagging separately
> -------------------------------------------------------------------------------------
>                 Key: LIBCLOUD-930
>                 URL:
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>            Reporter: Tom Morris
> While LIBCLOUD-690 is a real bug, it'd be moot if things were done correctly with the
tagging metadata being provided to the AWS RunInstances call where it could be applied atomically
with the creation of the node. The current style of doing it in two separate calls allows
for a window where nodes can get created without their associated tags, making accounting
for them much more difficult.

This message was sent by Atlassian JIRA

View raw message