libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ldipenti <...@git.apache.org>
Subject [GitHub] libcloud pull request #1100: Use TagSpecification parameter on EC2 create_no...
Date Wed, 30 Aug 2017 20:48:45 GMT
GitHub user ldipenti opened a pull request:

    https://github.com/apache/libcloud/pull/1100

    Use TagSpecification parameter on EC2 create_node

    ## Take advantage of AWS EC2 tag-on-create feature
    
    ### Description
    
    This small patch changes the way EC2 compute nodes are tagged when created, by adding
the tags on the creation call instead of doing it immediately after. This avoids eventual
consistency issues that sometimes happen when an instance isn't created yet so it can't be
tagged.
    
    For reference, the AWS docs are here: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_RunInstances.html
    
    This PR would tackle a colleague of mine has reported some weeks ago:
    https://issues.apache.org/jira/browse/LIBCLOUD-930
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [X] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes) (I've just submitted it.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/curoverse/libcloud apache-libcloud-2.2.0.dev1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1100
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message