libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pquentin <...@git.apache.org>
Subject [GitHub] libcloud pull request #1118: Improve CA_CERTS_PATH defined as list warning
Date Mon, 02 Oct 2017 05:14:37 GMT
GitHub user pquentin opened a pull request:

    https://github.com/apache/libcloud/pull/1118

    Improve CA_CERTS_PATH defined as list warning

    ## Improve "CA_CERTS_PATH defined as list" warning
    
    ### Description
    
    See https://github.com/apache/libcloud/pull/1114 for details. As requested by @Kami:
    
    > Not related to your change, but I would prefer this message to be a bit more explicit
and user-friendly - https://github.com/apache/libcloud/blob/trunk/libcloud/http.py#L153. And
perhaps also point user to the corresponding documentation section.
    
    Is it better? Should the URL be included?
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pquentin/libcloud ca-list-better-warning

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1118
    
----
commit 09f9701f6f8ead907a2ae92e60f7749091c57c8a
Author: Quentin Pradet <quentinp@apache.org>
Date:   2017-10-02T04:36:22Z

    Improve CA_CERTS_PATH defined as list warning

----


---

Mime
View raw message