libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mlackman <...@git.apache.org>
Subject [GitHub] libcloud pull request #1125: [LIBCLOUD-953] Add possibility to define userna...
Date Sun, 08 Oct 2017 13:51:02 GMT
GitHub user mlackman opened a pull request:

    https://github.com/apache/libcloud/pull/1125

    [LIBCLOUD-953] Add possibility to define username to Upcloud driver

    ex_username parameter added and refactored test to use common parameters
    
    ## ex_username added to create_node
    
    ### Description
    
    Added ex_username to create_node, so that clients can define username, which is created
to host.
    The default username is 'root', which is UpCloud's REST API's default username.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    -  [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/UpCloudLtd/libcloud LIBCLOUD-953_Add_possibility_to_define_username_to_UpCloud_driver

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1125
    
----
commit 3417ba9b97cd8a58b80e2c24d252bb8678ce247d
Author: Mika Lackman <mika.lackman@upcloud.com>
Date:   2017-10-07T16:31:53Z

    ex_username parameter added and
    refactored test to use common parameters

----


---

Mime
View raw message