libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zym-ustc <...@git.apache.org>
Subject [GitHub] libcloud pull request #1140: Modify XML for Aliyun ECS: describe_security_gr...
Date Thu, 09 Nov 2017 07:54:37 GMT
GitHub user zym-ustc opened a pull request:

    https://github.com/apache/libcloud/pull/1140

    Modify XML for Aliyun ECS: describe_security_group_attributes

    ## Aliyun ECS: Modify describe_security_group_attributes.xml
    
    ### Description
    
    When I read the code in ecs.py, I find [describe_security_group_attributes.xml](https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/fixtures/ecs/describe_security_group_attributes.xml)
doesn't match its title.
    Then I replace the content with the actual result.
    
    Reference: [Aliyun API Doc - DescribeSecurityGroupAttribute](https://help.aliyun.com/document_detail/25555.html?spm=5176.doc25556.6.893.9yP6oY)
    
    ### Status
    
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zym-ustc/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1140
    
----
commit 67f4411dde4cf77e8c5b89aee39bc87ff37e417b
Author: root <root@localhost.localdomain>
Date:   2017-11-09T07:18:46Z

    modify XML for Aliyun ECS: describe_security_group_attributes

----


---

Mime
View raw message