libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pquentin <...@git.apache.org>
Subject [GitHub] libcloud pull request #1161: Reduce `tox -e lint` verbosity
Date Tue, 09 Jan 2018 11:54:34 GMT
GitHub user pquentin opened a pull request:

    https://github.com/apache/libcloud/pull/1161

    Reduce `tox -e lint` verbosity

    ## Reduce `tox -e lint` verbosity
    
    ### Description
    
    By default, `python -m json.tool` prints to stdout, which makes `tox -e lint` really verbose.
This change keeps the errors, if any, but discards the result. There is no automated test
to add, but I did check that we were seeing the errors when the input file was not well formed.

    
    `/dev/null` won't work on Windows, but we already use /bin/bash for `tox -e docs`. Is
Windows supported by libcloud? If it is, we should add Appveyor CI. At that point, I'll stop
using json.tool for `tox -e lint` but will write a simple Python scripts that uses the `json`module.
    
    Thoughts?
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pquentin/libcloud lint-verbosity

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1161
    
----
commit 64bf038687753cb89a753c49728d17c7ab1bbef7
Author: Quentin Pradet <quentinp@...>
Date:   2018-01-09T11:45:35Z

    Reduce `tox -e lint` verbosity

----


---

Mime
View raw message