GitHub user SamuelMarks reopened a pull request:
https://github.com/apache/libcloud/pull/1042
[compute] [azure_arm] New fixtures, and minor changes to work with new API
## Updated fixtures; `"`⇒`'`; minor fixes to reflect newly cased JSON keys; and using
datetime library.
### Description
Was careful not to deprecate previous approaches, by using `.get` rather than just replacing
the key name to the new one, as not sure if that new one is used in all interfaces from Microsoft.
`datetime` usage also is clearer to read, not to mention still supporting the epoch syntax
[if MS still gives that somewhere?].
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SamuelMarks/libcloud azure_arm_patches
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1042.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1042
----
commit 3dbea4d93d5310c3d968f75604d615d442c6bcdc
Author: Samuel Marks <samuelmarks@...>
Date: 2017-04-24T01:25:00Z
Added link to Azure cross-platform CLI; updated CLI commands to reflect current version.
commit 562aad3f376fd494f18cb30dcb7a9d4a99a2ff69
Author: Samuel Marks <samuelmarks@...>
Date: 2017-04-24T11:47:43Z
[compute] [azure_arm] Updated fixtures; "=>'; minor fixes to reflect newly cased JSON
keys; and using datetime library
commit 66bc9460d57406719a34f1a93115c4b6140aa20e
Author: Samuel Marks <samuelmarks@...>
Date: 2017-04-24T15:28:59Z
[docs] [compute] [azure_arm] Added docs around setup with Azure CLI v2.
commit 858bab7d2babc9f1ce6a34c0f737aea92e94f248
Author: Samuel Marks <samuelmarks@...>
Date: 2017-04-25T13:04:03Z
[docs] [compute] [azure_arm] Fixed short-circuiting bug and updating docs.
----
---
|