libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ktdreyer <...@git.apache.org>
Subject [GitHub] libcloud pull request #1249: openstack: handle missing user email
Date Mon, 22 Oct 2018 19:46:25 GMT
GitHub user ktdreyer opened a pull request:

    https://github.com/apache/libcloud/pull/1249

    openstack: handle missing user email

    ### Description
    
    Keystone may not always return an "email" entry for a user account.
    Prior to this change, we could crash if we queried a user that lacked an
    email record. Gracefully handle this case by setting email to None.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ktdreyer/libcloud optional-email-openstack-user

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1249
    
----

----


---

Mime
View raw message