libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cheald <...@git.apache.org>
Subject [GitHub] libcloud pull request #1265: Override the auth header for the VCloud 5.5 Con...
Date Tue, 04 Dec 2018 16:54:55 GMT
GitHub user cheald opened a pull request:

    https://github.com/apache/libcloud/pull/1265

    Override the auth header for the VCloud 5.5 Connection

    ## Override the auth header for the VCloud 5.5 Connection
    
    ### Description
    
    Newer VCD installs (I'm working against API level 30.0, for reference) enforce a minimum
API level on authentication. This simply causes the authentication payload to send a version
5.5 header rather than a version 1.5 header, so our auth request isn't rejected.
    
    ### Status
    
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cheald/libcloud vcloud-5-5-auth-header

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1265
    
----
commit 508cc3c0baaa7320193e3c4c74aa91407594f983
Author: Chris Heald <cheald@...>
Date:   2018-12-04T16:50:43Z

    Override the auth header for the VCloud 5.5 Connection
    
    Newer VCD installs enforce a minimum API level on authentication. This
    simply causes the authentication payload to send a version 5.5 header
    rather than a version 1.5 header, so our auth request isn't rejected.

----


---

Mime
View raw message