GitHub user utam0k opened a pull request:
https://github.com/apache/libcloud/pull/1266
Dummy Node ID doesn't allow 0
## Dummy Node ID doesn't allow 0
### Description
If Dummy Node ID is `0`, it sets `None` when Node init.
Refs: https://github.com/apache/libcloud/blob/v2.4.0/libcloud/compute/base.py#L205
I think this is not the expected behavior.
So, I did not to allow it is `0`.
Before
```
[(None, 'dummy-0'), ('1', 'dummy-1'), ('2', 'dummy-2')]
```
After
```
[('1', 'dummy-1'), ('2', 'dummy-2')]
```
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/utam0k/libcloud trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1266
----
commit beb4de39a763cdcd018ce2cef06407ccb8f67ec7
Author: utam0k <k0ma@...>
Date: 2018-12-05T05:17:36Z
Dummy Node ID doesn't allow 0
----
---
|