libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] ryanpetrello commented on a change in pull request #1280: Replace all usage of PyCrypto with python-cryptography
Date Tue, 19 Mar 2019 19:08:59 GMT
ryanpetrello commented on a change in pull request #1280: Replace all usage of PyCrypto with
python-cryptography
URL: https://github.com/apache/libcloud/pull/1280#discussion_r267053860
 
 

 ##########
 File path: libcloud/utils/py3.py
 ##########
 @@ -126,7 +126,7 @@ def tostring(node):
 
     def hexadigits(s):
         # s needs to be a byte string.
-        return [format(x, "x") for x in s]
+        return [format(x, "02x") for x in s]
 
 Review comment:
   Ended up noticing a discrepancy between py2 and py3 here for integers `0-9` i.e.,
   
   `:3:` vs `:03:`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message