libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1281: Add router management functions in OpenStack
Date Sun, 26 May 2019 15:16:51 GMT
Kami commented on a change in pull request #1281: Add router management functions in OpenStack
URL: https://github.com/apache/libcloud/pull/1281#discussion_r287602455
 
 

 ##########
 File path: libcloud/compute/drivers/openstack.py
 ##########
 @@ -2979,7 +3012,7 @@ def ex_list_subnets(self):
             self._subnets_url_prefix).object
         return self._to_subnets(response)
 
-    def ex_create_subnet(self, name, network, cidr, ip_version=4):
+    def ex_create_subnet(self, name, network, cidr, ip_version=4, **kwargs):
 
 Review comment:
   I would prefer to explicitly declare support arguments. Using ``**kwargs`` makes it impossible
/ hard to see which arguments method takes without checking the code. It also makes automatic
code introspection impossible.
   
   https://libcloud.readthedocs.io/en/latest/development.html#don-t-abuse-kwargs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message