libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on issue #1281: Add router management functions in OpenStack
Date Sun, 26 May 2019 15:19:02 GMT
Kami commented on issue #1281: Add router management functions in OpenStack
URL: https://github.com/apache/libcloud/pull/1281#issuecomment-496008510
 
 
   Thanks for the contribution.
   
   From a high level the code change looks good to me (besides some concerns of using ``**kwargs``.
Since this functionality is available by multiple providers, we should eventually see if we
can introduce a new networking API.
   
   Something along the lines of #345.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message