libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1284: LIBCLOUD-1040_CloudSigma_provider_ex_list_subscriptions_fails_if_your…
Date Sun, 26 May 2019 18:08:58 GMT
Kami commented on a change in pull request #1284: LIBCLOUD-1040_CloudSigma_provider_ex_list_subscriptions_fails_if_your…
URL: https://github.com/apache/libcloud/pull/1284#discussion_r287608631
 
 

 ##########
 File path: libcloud/utils/iso8601.py
 ##########
 @@ -114,6 +114,8 @@ def parse_date(datestring, default_timezone=UTC):
     default timezone specified in default_timezone is used. This is UTC by
     default.
     """
+    if datestring is None:
 
 Review comment:
   I think it would be better to handle this differently (returning "random" date is almost
never a good idea) - either return None in such scenario or throw an exception if datestring
is None and handle that exception in CloudSigma driver code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message