libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] c-w opened a new pull request #1294: [LIBCLOUD-851] Fix azure_blobs driver with BlobStorage account
Date Fri, 31 May 2019 17:20:22 GMT
c-w opened a new pull request #1294: [LIBCLOUD-851] Fix azure_blobs driver with BlobStorage
account
URL: https://github.com/apache/libcloud/pull/1294
 
 
   ## Fix azure_blobs driver with BlobStorage account
   
   ### Description
   
   As discussed in [LIBCLOUD-851](https://issues.apache.org/jira/browse/LIBCLOUD-851), the
Azure Storage driver currently doesn't work when used against a storage account that was created
using `kind=BlobStorage` ([see failed integration test](https://clewolff.visualstudio.com/libcloud-tests/_build/results?buildId=71)).
This is because BlobStorage accounts only work with API version `2014-02-14` or newer ([see
docs](https://docs.microsoft.com/en-us/rest/api/storageservices/versioning-for-the-azure-storage-services)).
Updating the API version fixes the problem and doesn't affect the other types of storage accounts
([see passed integration test](https://clewolff.visualstudio.com/libcloud-tests/_build/results?buildId=72)).
   
   ### Status
   
   - done, ready for review
   - [CI passed](https://travis-ci.org/CatalystCode/libcloud/builds/539805150)
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
   - [ ] Documentation *(bugfix)*
   - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
*(bugfix)*

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message