libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] cicorias commented on a change in pull request #1294: [LIBCLOUD-851] Fix azure_blobs driver with BlobStorage account
Date Mon, 10 Jun 2019 22:33:26 GMT
cicorias commented on a change in pull request #1294: [LIBCLOUD-851] Fix azure_blobs driver
with BlobStorage account
URL: https://github.com/apache/libcloud/pull/1294#discussion_r292216873
 
 

 ##########
 File path: libcloud/test/storage/fixtures/azure_blobs/list_containers_1.xml
 ##########
 @@ -1,10 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
-<EnumerationResults AccountName="https://account.blob.core.windows.net/">
+<EnumerationResults ServiceEndpoint="https://account.blob.core.windows.net/">
     <MaxResults>2</MaxResults>
     <Containers>
         <Container>
             <Name>container1</Name>
 
 Review comment:
   any chance of a collision or orphaned results here? Maybe a random container name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message