libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1300: ec2 list_volumes should accept more filters
Date Mon, 01 Jul 2019 21:13:52 GMT
Kami commented on a change in pull request #1300: ec2 list_volumes should accept more filters
URL: https://github.com/apache/libcloud/pull/1300#discussion_r299220031
 
 

 ##########
 File path: libcloud/test/compute/test_ec2.py
 ##########
 @@ -1548,6 +1553,26 @@ def _DescribeVolumes(self, method, url, body, headers):
         body = self.fixtures.load('describe_volumes.xml')
         return (httplib.OK, body, {}, httplib.responses[httplib.OK])
 
+    def _filters_DescribeVolumes(self, method, url, body, headers):
+        expected_params_1 = {
+            'Filter.1.Name': 'attachment.instance-id',
+            'Filter.1.Value.1': 'i-d334b4b3',
+        }
+
+        expected_params_2 = {
+            'Filter.1.Name': 'status',
+            'Filter.1.Value.1': 'available'
+        }
+
+        try:
+            self.assertUrlContainsQueryParams(url, expected_params_1)
 
 Review comment:
   I just checked and see the method already supports that.
   
   It's just the way tests are structured. This should do it - f8deceb04c41e36bc3002b3fd9c4f0d6e752b383.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message