libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on issue #1306: [WIP] Add Python type annotation for base APIs
Date Wed, 10 Jul 2019 09:05:07 GMT
Kami commented on issue #1306: [WIP] Add Python type annotation for base APIs
URL: https://github.com/apache/libcloud/pull/1306#issuecomment-509977969
 
 
   In addition to my comment above - I also decided I will start with an API per pull request
to make sure the PRs don't grow too large.
   
   In this PR I will work on the compute API and other common code which is needed to get
that to work.
   
   As far as type annotations for our dynamically returned provider drivers go - I still haven't
been able to figure this out.
   
   We may just need to go with returning a reference to the base NodeDriver. It's not ideal
since it won't know about any provider class specific methods and arguments, but I'm not even
sure yet if we can correctly annotate our code which does our dynamic driver class loading
(we may need a MyPy plugin or it may even not be possible).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message