libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami opened a new pull request #1308: pylint improvements and pylint support for libcloud/compute/ directory
Date Wed, 10 Jul 2019 15:22:29 GMT
Kami opened a new pull request #1308: pylint improvements and pylint support for libcloud/compute/
directory
URL: https://github.com/apache/libcloud/pull/1308
 
 
   This pull request hooks up ``pylint`` lint checks on the ``libcloud/compute/`` directory.
   
   Previously we didn't run it on that directory, because it included too many issues and
false positives.
   
   To get it to work, I needed write a custom pylint plugin which tells pylint how to handle
special ``connection`` attribute on the provider driver classes.
   
   This attribute is special, because it's dynamically assigned during run-time inside the
driver constructor based on the value of ``connectionCls`` driver class attribute. As such,
pylint is not aware of it.
   
   The changes already exposed some actual issues in the code (bad / incorrect multiple inheritance,
referencing invalid variables, etc.).
   
   Sadly not all of those things can be fixed easily so I needed to fall back to ``# pylint:
disable`` in some scenarios.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message