libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] c-w commented on a change in pull request #1292: [LIBCLOUD-1001] Update Cloudflare DNS driver to API v4
Date Mon, 15 Jul 2019 22:47:15 GMT
c-w commented on a change in pull request #1292: [LIBCLOUD-1001] Update Cloudflare DNS driver
to API v4
URL: https://github.com/apache/libcloud/pull/1292#discussion_r303667734
 
 

 ##########
 File path: libcloud/dns/drivers/cloudflare.py
 ##########
 @@ -141,290 +159,252 @@ class CloudFlareDNSDriver(DNSDriver):
         RecordType.URL: 'LOC'
     }
 
+    PAGE_SIZE = 20
 
 Review comment:
   Good idea. I've increased the page size to the API maximum (instead of the previous API
default value) in 9970385.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message