libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] gluap opened a new pull request #1384: Only guess host from region map if not explicitly set
Date Fri, 13 Dec 2019 11:00:22 GMT
gluap opened a new pull request #1384: Only guess host from region map if not explicitly set
URL: https://github.com/apache/libcloud/pull/1384
 
 
   
   
   ## Only guess host from region map if not explicitly set
   
   ### Description
   
   Overwriting host parameter is inconsistent with function signature and a breaking change
compared with previous behavior. This change will respect the host if passed by the user but
guess from the region if not explicitly passed.
   
   Reason: If the user passes a host he expects it to be respected, be it because he wants
to use a local proxy, test against a local server or any other reason not to use one of the
predefined amazon servers.
   
   This fixes #1383 .
   
   ### Status
   
   done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
       should pass (tried to keep pep8 for that one extra line)
   - [x] Documentation
       small bug fix restores consistent behaviour -- no change vs documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
       couldn't run them locally because I used the github online editor but I guess CI will
do that right? 
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
       a one liner surely doesn't require this.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message