libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] yukw777 opened a new pull request #1387: GCENodeDriver's deploy_node() now accepts Deployments as well as all the parameters accepted by create_node()
Date Mon, 16 Dec 2019 19:06:00 GMT
yukw777 opened a new pull request #1387: GCENodeDriver's deploy_node() now accepts Deployments
as well as all the parameters accepted by create_node()
URL: https://github.com/apache/libcloud/pull/1387
 
 
   ## GCENodeDriver's deploy_node() now accepts Deployments as well as all the parameters
accepted by create_node()
   
   ### Description
   
   I've deleted the overridden `deploy_node()` function from `GCENodeDriver` so that it'd
use base `NodeDriver`'s `deploy_node()` instead. This allows users to pass in `Deployment`s
and other parameters accepted by `create_node()`.
   
   ### Status
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
   - [x] Documentation
   - [x] [Tests] I didn't add new unit tests as I'm merely removing a function, and the base
`deploy_node()` should be covered by existing tests. I did manually test with my GCE account.
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
I think this is a small change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message