libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on issue #1387: GCENodeDriver's deploy_node() now accepts Deployments as well as all the parameters accepted by create_node()
Date Tue, 17 Dec 2019 21:15:12 GMT
Kami commented on issue #1387: GCENodeDriver's deploy_node() now accepts Deployments as well
as all the parameters accepted by create_node()
URL: https://github.com/apache/libcloud/pull/1387#issuecomment-566752017
 
 
   Thanks for the contribution.
   
   I will need to take a look at this in more detail and perhaps also test it to see if we
can get rid of ``**kwargs``.
   
   I know it's used in other places, but it's legacy code and in general a bad practice since
it makes code very hard to follow and understand (and it also masks various issues since the
method just silently accepts arbitrary arguments).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message