libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on issue #1397: Enable `ex_prefix` to be passed via all storage SDK methods
Date Thu, 26 Dec 2019 22:15:11 GMT
Kami commented on issue #1397: Enable `ex_prefix` to be passed via all storage SDK methods
URL: https://github.com/apache/libcloud/pull/1397#issuecomment-569141710
 
 
   Overall, I'm fine with this change, but another option would be to simply name the argument
``prefix`` (aka promote it to be part of the base API).
   
   Then we could also have a fallback, if driver doesn't implement ``_filter_objects_by_prefix``
method (or similar) we would simply fall back to the implementation on the base driver which
performs simple local filtering on the whole result set.
   
   Since that method would perform filtering locally, it would probably also be a good idea
to document that behavior (perhaps also emit a warning?) to avoid surprises.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message