libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1553: Respect common HTTP headers when uploading Azure Storage blob via stream
Date Mon, 08 Feb 2021 10:35:25 GMT

Kami commented on a change in pull request #1553:
URL: https://github.com/apache/libcloud/pull/1553#discussion_r571939041



##########
File path: libcloud/storage/drivers/azure_blobs.py
##########
@@ -929,6 +932,31 @@ def delete_object(self, obj):
 
         return False
 
+    def _fix_headers(self, headers):

Review comment:
       Can you please add some unit tests for this method / functionality?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message