libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] c-w commented on a change in pull request #1553: Respect common HTTP headers when uploading Azure Storage blob via stream
Date Mon, 08 Feb 2021 21:32:27 GMT

c-w commented on a change in pull request #1553:
URL: https://github.com/apache/libcloud/pull/1553#discussion_r572388297



##########
File path: libcloud/storage/drivers/azure_blobs.py
##########
@@ -929,6 +932,31 @@ def delete_object(self, obj):
 
         return False
 
+    def _fix_headers(self, headers):

Review comment:
       Fitting this into the mock request/response framework was proving challenging so I
added an isolated test for the new normalization functionality in 98cd383. I also added an
integration test for this scenario in https://github.com/c-w/libcloud-tests/commit/e305b9d34276f50543b8c3a5f342eb18f04fe945.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message