libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] c-w commented on a change in pull request #1553: Respect common HTTP headers when uploading Azure Storage blob via stream
Date Tue, 09 Feb 2021 21:37:02 GMT

c-w commented on a change in pull request #1553:
URL: https://github.com/apache/libcloud/pull/1553#discussion_r573259280



##########
File path: libcloud/storage/drivers/azure_blobs.py
##########
@@ -929,6 +932,31 @@ def delete_object(self, obj):
 
         return False
 
+    def _fix_headers(self, headers):

Review comment:
       I believe the test failure may be linked to an issue in AzuriteV3, see https://github.com/Azure/Azurite/issues/629#issuecomment-776258485.
Given that the test passes for all other storage targets, I disabled the test for AzuriteV3
in https://github.com/c-w/libcloud-tests/commit/b2be083358cfe3898aff50bb380c175cbf8ea2aa.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message