libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1543: Minor fix getting description of Ports
Date Fri, 12 Feb 2021 10:30:25 GMT

Kami commented on a change in pull request #1543:
URL: https://github.com/apache/libcloud/pull/1543#discussion_r575126130



##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -2874,7 +2874,7 @@ def _to_port(self, element):
                 allowed_address_pairs=element['allowed_address_pairs'],
                 binding_vnic_type=element['binding:vnic_type'],
                 device_id=element['device_id'],
-                description=element['description'],
+                description=element.get('description', None),

Review comment:
       If you get a chance it would also be good to add a test case for it + changelog entry.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message