libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] outscale-fne commented on pull request #1549: Make libcloud compliant with the latest Outscale API.
Date Tue, 23 Feb 2021 09:06:23 GMT

outscale-fne commented on pull request #1549:
URL: https://github.com/apache/libcloud/pull/1549#issuecomment-784020716


   > Thanks for the contribution.
   > 
   > I've added some in-line comments.
   > 
   > Mostly needs some argument default value clean up and adding some additional checks
to the method where at least one filter argument needs to be provided.
   
   Thank you sir for reviewing! It seems we misunderstood a part af the conding rules... I
am patching right now!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message