libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] Kami commented on a change in pull request #1564: Enable auth to Cloudflare DNS via API Tokens
Date Sat, 13 Mar 2021 19:58:32 GMT

Kami commented on a change in pull request #1564:
URL: https://github.com/apache/libcloud/pull/1564#discussion_r593793990



##########
File path: libcloud/dns/drivers/cloudflare.py
##########
@@ -146,27 +147,37 @@ def parse_error(self):
             raise exception_class(**kwargs)
 
 
-class CloudFlareDNSConnection(ConnectionUserAndKey):
+class BaseDNSConnection:

Review comment:
       Minor style thing - we tend to explicitly inherit from object everywhere.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message