libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] tonybaloney commented on pull request #1572: Add integration tests for Azure Storage driver
Date Tue, 23 Mar 2021 21:07:02 GMT

tonybaloney commented on pull request #1572:
URL: https://github.com/apache/libcloud/pull/1572#issuecomment-805260481


   I've put in an internal request at Microsoft for some credit.
   
   I'll ping back on here when/if it gets approved
   
   On Wed, Mar 24, 2021 at 1:18 AM Clemens Wolff ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In integration/storage/base.py
   > <https://github.com/apache/libcloud/pull/1572#discussion_r599610000>:
   >
   > > +                value = getattr(self, required, None)
   > +                if value is None:
   > +                    raise unittest.SkipTest('config {} not set'.format(required))
   > +
   > +            kwargs = {'key': self.account, 'secret': self.secret}
   > +
   > +            for optional in 'host', 'port', 'secure':
   > +                value = getattr(self, optional, None)
   > +                if value is not None:
   > +                    kwargs[optional] = value
   > +
   > +            driver_class = providers.get_driver(self.provider)
   > +            self.driver = driver_class(**kwargs)
   > +
   > +        def tearDown(self):
   > +            for container in self.driver.list_containers():
   >
   > Done in 0c4d093
   > <https://github.com/apache/libcloud/commit/0c4d09376c824eb542743fc225fc30c22ab39bc9>
   > .
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/libcloud/pull/1572#discussion_r599610000>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AALWEAJV7Q7DO3ZMT5IMGXTTFCPKHANCNFSM4ZQSB2FA>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message