libcloud-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [libcloud] atarbalouti opened a new pull request #1602: fix linux command deployment when running libcloud on windows
Date Tue, 14 Sep 2021 08:17:19 GMT

atarbalouti opened a new pull request #1602:
URL: https://github.com/apache/libcloud/pull/1602


   ## Fix right path composition suited for destination machine
   
   ### Description
   
   When running libcloud on Windows to deploy a linux machine in the cloud with a ScriptDeployment,
it had always promted me an error which was like "stderr: bash: /home/googlelibcloud_deployment_b20d6e1e.sh:
No such file or directory". So, the path was not right formatted. The error was in the os.path.join
method, which produces a false path on windows like "/home/google\\libcloud_deployment_b20d6e1e.sh".
So I had to add the .replace("\\","/") method to the os.path.join.
   
   ### Status
   
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
   - [ ] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message