logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Smith" <psm...@aconex.com>
Subject RE: cvs commit: logging-log4j/src/java/org/apache/log4j/chainsaw/help release-notes.html
Date Sun, 01 Aug 2004 22:10:15 GMT
I'm curious about the below change.  I would have thought the code should
notify listeners when the information the rule is based on is changed?
Could you describe why we need to remove that line?  

Paul
> 
>   Index: RuleColorizer.java
>   ===================================================================
>   RCS file: /home/cvs/logging-
> log4j/src/java/org/apache/log4j/chainsaw/color/RuleColorizer.java,v
>   retrieving revision 1.9
>   retrieving revision 1.10
>   diff -u -r1.9 -r1.10
>   --- RuleColorizer.java	28 Jul 2004 08:02:17 -0000	1.9
>   +++ RuleColorizer.java	31 Jul 2004 07:23:58 -0000	1.10
>   @@ -117,7 +117,6 @@
> 
>      public void clear() {
>        rules.clear();
>   -    colorChangeSupport.firePropertyChange("colorrule", false, true);
>      }
> 
>      public void removeRule(String ruleSetName, String expression) {


---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message