logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 41476] New: - Address "findbugs" (findbugs.sf.net) issues
Date Fri, 26 Jan 2007 17:52:17 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41476>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41476

           Summary: Address "findbugs" (findbugs.sf.net) issues
           Product: Log4j
           Version: 1.3alpha
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Other
        AssignedTo: log4j-dev@logging.apache.org
        ReportedBy: genman@noderunner.net


Issues include correctness and consistency and clarity problems found by this
tool. For example:

Finalizer does not call superclass finalizer

This finalize() method does not make a call to its superclass's finalize()
method. So, any finalizer actions defined for the superclass will not be
performed. Add a call to 
 super.finalize().

Class defines equals() and uses Object.hashCode()

This class overrides equals(Object), but does not override hashCode(), and
inherits the implementation of hashCode() from java.lang.Object (which returns
the identity 
 hash code, an arbitrary value assigned to the object by the VM). Therefore, the
class is very likely to violate the invariant that equal objects must have equal 
 hashcodes. 

Wait not in loop

This method contains a call to java.lang.Object.wait() which is not in a loop.
If the monitor is used for multiple conditions, the condition the caller
intended to wait for might not be the one that actually occurred.

instanceof will always return true

This instanceof test will always return true. Although this is safe, make sure
it isn't an indication of some misunderstanding or some other logic error.


etc.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message