logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 43619] - Simple proposal for pluggable sys-props resolvers
Date Thu, 25 Oct 2007 21:26:26 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43619>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43619





------- Additional Comments From carnold@apache.org  2007-10-25 14:26 -------
Quite a bit less than 100%.  I did a quick read through the patch and apparently came to a
faulty 
conclusion.

There is an arbitrariness of where you stop using System.getProperty().  If you rework 
OptionConverter.getSystemProperty() (instead of OptionConverter.substVars) to use a user-specified

source for properties, then you could have JMX specify the default configurator, etc.  The
source for 
"system properties" would be the only property that would have to come from System.getProperty().

I'd like to avoid adding a new interface, but overriding Map seems like an inordinate amount
of effort 
and likely to be short-cut.  Plus it is hard to explain what the effective value of the current
behavior is.  
Perhaps a property ("log4j.systemPropertyClass" ?) could specify a class name whose getProperty(String)

method would be used for system properties.  The effective default value would be "java.lang.System".


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message