logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44108] - Telnet Appender misses messages
Date Thu, 17 Jan 2008 20:27:33 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44108>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44108


carnold@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From carnold@apache.org  2008-01-17 12:27 -------
Committed a change in rev 612959 that should address the same issues with less code changes.

 JDK 1.2 added Iterator as a replacement for Enumerator and Iterator.remove() can safely remove
an 
element while iterating.  So SocketHandler.send was rewritten using Iterator. 

The occasions that writers and connections could get out of sync would be when a connection
is being 
accepted while a message is being sent.  I've added sync blocks so that any access to connections
or 
writers must have a lock of SocketHandler.  You could rewrite everything so that you could
safely 
accept a connection while messages were being sent, but that seems to be overkill.

The Telnet RFC does require CRLF's.  The main message requires that you specify the layout
including 
the line feed, so you should not use %n in a layout with TelnetAppender.  It would be possible
to fix 
this after the fact, but I haven't attempted that.  I did change the EOL's used in the exception
messages.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message