logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44109] - Telnet Appender throws null pointers at log time when socket couldn't be opened
Date Thu, 17 Jan 2008 21:52:08 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44109>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44109





------- Additional Comments From carnold@apache.org  2008-01-17 13:52 -------
I added a check for null at the head of TelnetAppender.append in rev 612911, to see just that
change 
use svn diff like:

svn diff -r 612910:612911

I'd appreciate your feedback on the recently checked in code.  I did look at the code in the
comments 
of 44108, but could not use it due to the JDK 1.5 stuff.  The rework to have a single collection
is good, 
but it was a lot simpler to add the sync blocks and they needed them anyway even if there
was just one 
collection.

There are two more global issues that you have mentioned:

the lack of programmatic feedback on configuration or start up issues
the lack of a try/catch/finally block in Categories.callAppenders or the like to catch unexpected

exceptions during logging.

The lack of programmatic feedback is a log4j 2.0 issue.   log4j 1.2 made its design decisions
6 or so 
years ago and we are generally stuck with them for maintenance releases.

The lack of a try/catch/finally block the Logger level was also made at that same time.  Adding
it now 
would affect the performance of every log4j user, not just those who were using TelnetAppender,
 Not 
that it would be a bad idea, but it is less likely to have serious unexpected consequences
to make a 
isolated local change than a global change.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message