logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40888] Weekly rotation problem in Europe
Date Mon, 30 Jun 2008 21:18:02 GMT

Thorbjørn Ravn Andersen <thorbjoern@gmail.com> changed:

           What    |Removed                     |Added
                 CC|                            |thorbjoern@gmail.com

--- Comment #1 from Thorbjørn Ravn Andersen <thorbjoern@gmail.com>  2008-06-30 14:18:02
PST ---
This does not appear to have been addressed yet.  The code in question is that

the "roll over"-time is calculated to be

    case DailyRollingFileAppender.TOP_OF_WEEK:
        this.set(Calendar.DAY_OF_WEEK, getFirstDayOfWeek());
        this.set(Calendar.HOUR_OF_DAY, 0);
        this.set(Calendar.MINUTE, 0);
        this.set(Calendar.SECOND, 0);
        this.set(Calendar.MILLISECOND, 0);
        this.add(Calendar.WEEK_OF_YEAR, 1);

and the loop is

     for(int i = TOP_OF_MINUTE; i <= TOP_OF_MONTH; i++) {
        SimpleDateFormat simpleDateFormat = new SimpleDateFormat(datePattern);
        simpleDateFormat.setTimeZone(gmtTimeZone); // do all date formatting in
        String r0 = simpleDateFormat.format(epoch);
        Date next = new Date(rollingCalendar.getNextCheckMillis(epoch));
        String r1 =  simpleDateFormat.format(next);
        //System.out.println("Type = "+i+", r0 = "+r0+", r1 = "+r1);
        if(r0 != null && r1 != null && !r0.equals(r1)) {
          return i;

The r1 and r0 will be identical in the case described by the original poster.

Will it be sufficient in all cases to just ask the Calendar what the first day
of the week is as suggested in the bug report?

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

View raw message