logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@gmail.com>
Subject Re: svn commit: r1159035 - /logging/log4j/trunk/pom.xml
Date Thu, 18 Aug 2011 16:35:41 GMT
I think the main reason for antrun is to enhance the generated site
afterwards, and probably for publishing.
Most other stuff can be done with maven, so I would give my +1 to
reduce the Ant dependency to a minimum - again.

Imho antrun should not do any tests

On Thu, Aug 18, 2011 at 6:31 PM, Jacob Kjome <hoju@visi.com> wrote:
>
> This seems to be occurring in the Maven Antrun plugin.  I know that Ant's
> JUnit task requires JUnit to be in Ant's classpath, which would make it a
> runtime library for Ant.  That said, why is Antrun being used rather than
> directly running tests using Maven?  If Antrun is truly needed, couldn't
> JUnit be provided directly as an Antrun runtime dependency rather than a
> runtime dependency of the project as a whole?
>
> Jake
>
> On Thu, 18 Aug 2011 09:26:14 -0700
>  Scott Deboy <scott.deboy@gmail.com> wrote:
>>
>> So I don't get an error on Windows, but my Mac does get the error..here it
>> is:
>>
>> [INFO] Scanning for projects...
>> mvn site[ERROR] The build could not read 1 project -> [Help 1]
>> [ERROR]
>> [ERROR]   The project log4j:log4j:1.2.17-SNAPSHOT
>> (/Users/admin/work-local/log4j-trunk/log4j/pom.xml) has 1 error
>> [ERROR]
>>
>> 'build.plugins.plugin[org.apache.maven.plugins:maven-antrun-plugin].dependencies.dependency.scope'
>> for junit:junit:jar must be one of [compile, runtime, system] but is
>> 'test'.
>> @ line 321, column 20
>> [ERROR]
>> [ERROR] To see the full stack trace of the errors, re-run Maven with the
>> -e
>> switch.
>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>>
>> I'll look more closely into this.
>>
>> On Thu, Aug 18, 2011 at 7:36 AM, Christian Grobmeier
>> <grobmeier@gmail.com>wrote:
>>
>>> cool!
>>>
>>> On Thu, Aug 18, 2011 at 4:35 PM, Scott Deboy <scott.deboy@gmail.com>
>>> wrote:
>>> > I reverted the change and was still able to build.  I'm not sure why I
>>> had
>>> > that error.
>>> >
>>> > On Thu, Aug 18, 2011 at 7:24 AM, Christian Grobmeier <
>>> grobmeier@gmail.com>
>>> > wrote:
>>> >>
>>> >> weird.
>>> >>
>>> >> my suggestion is we leave it for now - but we must think about it
>>> >> shortly before the release. Because users will then need junit in
>>> >> their runtime which might annoy some of them :-)
>>> >>
>>> >> On Thu, Aug 18, 2011 at 4:05 PM, Scott Deboy <scott.deboy@gmail.com>
>>> >> wrote:
>>> >> > it failed to even build saying it must be one of build or
>>> >> > runtime.  I
>>> >> > saw
>>> >> > other test scopes in the poms so I was confused myself. Maybe an
>>> >> > issue
>>> >> > with
>>> >> > my environment?
>>> >> >
>>> >> >
>>> >> >
>>> >> > On Aug 18, 2011, at 12:51 AM, Christian Grobmeier <
>>> grobmeier@gmail.com>
>>> >> > wrote:
>>> >> >
>>> >> >> Not sure, but Junit should not be necessary for the runtime
>>> >> >> execution
>>> >> >> imho.
>>> >> >>
>>> >> >>
>>> >> >>
>>>
>>> http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html
>>> >> >>
>>> >> >> I think it should be test only.
>>> >> >>
>>> >> >> I did not work without having it on runtime?
>>> >> >>
>>> >> >> runtime
>>> >> >> This scope indicates that the dependency is not required for
>>> >> >> compilation, but is for execution. It is in the runtime and
test
>>> >> >> classpaths, but not the compile classpath.
>>> >> >> test
>>> >> >> This scope indicates that the dependency is not required for
normal
>>> >> >> use of the application, and is only available for the test
>>> compilation
>>> >> >> and execution phases.
>>> >> >>
>>> >> >> On Thu, Aug 18, 2011 at 7:10 AM,  <sdeboy@apache.org>
wrote:
>>> >> >>>
>>> >> >>> Author: sdeboy
>>> >> >>> Date: Thu Aug 18 05:10:58 2011
>>> >> >>> New Revision: 1159035
>>> >> >>>
>>> >> >>> URL: http://svn.apache.org/viewvc?rev=1159035&view=rev
>>> >> >>> Log:
>>> >> >>> Updating junit scope in pom.xml to runtime to get build
to work
>>> >> >>> with
>>> >> >>> maven 3.0.3
>>> >> >>>
>>> >> >>> Modified:
>>> >> >>>   logging/log4j/trunk/pom.xml
>>> >> >>>
>>> >> >>> Modified: logging/log4j/trunk/pom.xml
>>> >> >>> URL:
>>> >> >>>
>>> >> >>>
>>>
>>> http://svn.apache.org/viewvc/logging/log4j/trunk/pom.xml?rev=1159035&r1=1159034&r2=1159035&view=diff
>>> >> >>>
>>> >> >>>
>>> >> >>>
>>>
>>> ==============================================================================
>>> >> >>> --- logging/log4j/trunk/pom.xml (original)
>>> >> >>> +++ logging/log4j/trunk/pom.xml Thu Aug 18 05:10:58 2011
>>> >> >>> @@ -318,7 +318,7 @@ target platform and specify -Dntdll_targ
>>> >> >>>            <groupId>junit</groupId>
>>> >> >>>            <artifactId>junit</artifactId>
>>> >> >>>            <version>3.8.1</version>
>>> >> >>> -            <scope>test</scope>
>>> >> >>> +            <scope>runtime</scope>
>>> >> >>>          </dependency>
>>> >> >>>          <dependency>
>>> >> >>>            <groupId>sun.jdk</groupId>
>>> >> >>>
>>> >> >>>
>>> >> >>>
>>> >> >>>
>>> ---------------------------------------------------------------------
>>> >> >>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> >> >>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>> >> >>>
>>> >> >>>
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >> --
>>> >> >> http://www.grobmeier.de
>>> >> >>
>>> >> >>
>>> >> >> ---------------------------------------------------------------------
>>> >> >> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> >> >> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>> >> >>
>>> >> >
>>> >> >
>>> >> > ---------------------------------------------------------------------
>>> >> > To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> >> > For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>> >> >
>>> >> >
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> http://www.grobmeier.de
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> >> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>> >>
>>> >
>>> >
>>>
>>>
>>>
>>> --
>>> http://www.grobmeier.de
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>



-- 
http://www.grobmeier.de

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message