logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 45753] Code contribution: BurstFilter for extras
Date Sun, 02 Oct 2011 17:42:04 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753

--- Comment #8 from Chad LaVigne <chad_lavigne@yahoo.com> 2011-10-02 17:42:04 UTC ---
Thank you for adding this, I thought my contribution might be a lost cause. So
it looks like this is basically the same filter except that you no longer
define the fill amount, i.e. you say add tokens every 10 seconds but you don't
say how many to add every 10 seconds, correct?  I like that simplification, but
I do kind of like having the ability to configure the fill rate too. Maybe we
could allow the fill rate to still be configured but just have a sensible
default?

(In reply to comment #6)
> I implemented a BurstFilter that behaves a bit differently that yours to the
> Log4j 2.0 experimental branch.  It will behave a bit differently than yours in
> that it only needs the interval and queue size. You can find it at
> https://svn.apache.org/repos/asf/logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-core/src/main/java/org/apache/logging/log4j/core/filter/BurstFilter.java

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message