logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@gmail.com>
Subject Re: [VOTE] Release log4j 1.2.17 RC2
Date Sun, 06 May 2012 09:41:19 GMT
Hi,

On Sun, May 6, 2012 at 12:28 AM, Gary Gregory <ggregory@apache.org> wrote:
> One of the reason I voted -1 on RC1 is because the release notes where
> incomplete. They still are in RC2; still missing under "Release 1.2.17", is
> an entry for https://issues.apache.org/bugzilla/show_bug.cgi?id=52913 I
> added the missing entry to changes.xml.

ah now I understand the problem. First, when you send this issue in
the first mail, I was not able to open it. Somewhat happend to the
link which made it crap for me. I asked you about it with my response
to that mail, but you didn't respond. I thought it was because of the
other issues you mentioned. I fixed them and went ahead.

I was in doubt about this issue, because I didn't knew why it should
be on the list. I missed that you have committed it. Usually we fix
something and then the one who has fixed adds the issue number to
changes.xml.

As I have fixed the other issues, we should be complete by now.


> - Please tell us the difference between RC n and RC n+1 in the VOTE email.

I have responded to your vote-1 mail in detail. But of course
mentioning it on the new vote mail does not hurt.

> - The tag should have included the RC#, for example../tags/1_2_17-RC2

Before 1.2.17, we have created a tag with the original release name
and renamed it when a vote failed, like here: http://bit.ly/Ll9FLL

Your proposal is to create a name with RC in it, vote upon it and to
rename it after the vote is successful.

I am fine with both versions, therefore I will update BUILD-INFO.txt
to reflect that.

> - I find it the simplest to set the date of the release to the date of the
> RC, as opposed to what is in there now: "2010-06-99". If a vote passes, you
> do not need to edit the date again. This date example is from changes.xml.

+1

> On the positive, building with Maven is better. I can build the site on
> Windows with M2 and M3 with "mvn clean site", all is well for M2 and M3
> with "mvn clean test".

cool!
Anything one needs to know in special and should be documented?

> As noted before a full build is not possible on Windows with the set up as
> is, we'll have to live with that for now I think.

I think so. In my response to that matter I mentioned we could exlude
the NTEventAppender.dll from the log4j trunk and make it a companion.
Then it should be possible to have a platform independent build. WDYT?

OK... will reroll another RC soon

Cheers
Christiam

> <http://svn.apache.org/repos/asf/logging/site/trunk/docs/log4j/1.2/changes-report.html#a1.2.17>
> Gary
>
> On Fri, May 4, 2012 at 4:15 AM, Christian Grobmeier <grobmeier@gmail.com>
> wrote:
>>
>> Hello,
>>
>> please vote to release log4j 1.2.17 RC2.
>>
>> Artifacts:
>> http://people.apache.org/builds/logging/repo/log4j/log4j/
>>
>> Sources are included in the .zip files aswell.
>>
>> Tag:
>> http://svn.apache.org/repos/asf/logging/log4j/tags/v1_2_17/
>>
>> Website:
>>
>> http://svn.apache.org/repos/asf/logging/site/trunk/docs/log4j/1.2/index.html
>>
>> Please test carefully as this is my first log4j release.
>>
>> [] +1, release the artifacts
>> [] -1, don't release because
>>
>> The vote will remain open for the usual 72 hours.
>>
>> Thanks,
>> Christian
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory



-- 
http://www.grobmeier.de
https://www.timeandbill.de

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message