logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <rgo...@apache.org>
Subject Re: [VOTE] Release log4j 1.2.17
Date Wed, 02 May 2012 16:31:18 GMT
As usual, I've been pretty busy at work and haven't had a chance to look at this. I'm going
to Phoenix, AZ tomorrow to visit family through next Tuesday so I may not have time to do
much between now and then.

Ralph

On May 2, 2012, at 8:39 AM, Gary Gregory <ggregory@apache.org> wrote:

> Hi All,
> 
> -1, mostly because of the missing bug fixed in the release notes page. Are
> there others? It would be nice to fix everything below but I realize this
> is a maintenance release and we have 2.0 coming which I hope will deal with
> these other issues, if not already done.
> 
> http://people.apache.org/builds/logging/repo/log4j/log4j/ does not include
> bin and src zips (or tars if you like that) so I have to download the tag
> to test build.
> 
> *Build Issues*
> 
> I get these Maven warnings:
> 
> [WARNING] Some problems were encountered while building the effective model
> for log4j:log4j:bundle:1.2.17
> [WARNING] 'build.plugins.plugin.version' for
> org.apache.maven.plugins:maven-resources-plugin is missing. @ line 89,
> column
> [WARNING] 'build.plugins.plugin.version' for
> org.apache.maven.plugins:
> maven-site-plugin is missing. @ line 447, column 1=
> 5
> 
> I get this Maven error:
> 
> [WARNING] An issue has occurred with report
> org.apache.maven.report.projectinfo.DependenciesReport, skip LinkageError
> org.c
> gerManager()Lorg/codehaus/plexus/logging/LoggerManager;, please report an
> issue to Maven dev team.
> java.lang.NoSuchMethodError:
> org.codehaus.plexus.PlexusContainer.getLoggerManager()Lorg/codehaus/plexus/=
> logging/LoggerManag
>        at
> org.apache.maven.report.projectinfo.DependenciesReport.executeReport(Depend=
> enciesReport.java:222)
>        at
> org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport=
> .java:93)
>        at
> org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(ReportD=
> ocumentRenderer.java:228)
>        at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(Defaul=
> tSiteRenderer.java:317)
>        at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteR=
> enderer.java:134)
>        at
> org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:175)
>        at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:138=
> )
>        at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildP=
> luginManager.java:101)
>        at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:=
> 209)
>        at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:=
> 153)
>        at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:=
> 145)
>        at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(Lif=
> ecycleModuleBuilder.java:84)
>        at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(Lif=
> ecycleModuleBuilder.java:59)
>        at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(Li=
> fecycleStarter.java:183)
>        at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStart=
> er.java:161)
>        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
>        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>        at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:3=
> 9)
>        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImp=
> l.java:25)
>        at java.lang.reflect.Method.invoke(Method.java:597)
>        at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.j=
> ava:290)
>        at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>        at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher=
> .java:409)
>        at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> 
> I use "mvn clean site" with:
> 
> Apache Maven *3.0.4* (r1232337; 2012-01-17 03:44:56-0500)
> Maven home: C:\Java\apache-maven-3.0.4\bin\..
> Java version: 1.6.0_31, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_31\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> 
> With Maven 2, I cannot build at all, which is fine if it is documented:
> 
> [WARNING] Removing: javadoc from forked lifecycle, to prevent recursive
> invocation.
> <snip>
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] FATAL ERROR
> [INFO]
> ------------------------------------------------------------------------
> [INFO]
> org.apache.maven.doxia.siterenderer.sink.SiteRendererSink.figure(Lorg/apach=
> e/maven/doxia/sink/SinkEventAttributes;)V
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Trace
> java.lang.AbstractMethodError:
> org.apache.maven.doxia.siterenderer.sink.SiteRendererSink.figure(Lorg/apach=
> e/maven/doxia/sin
>        at
> org.apache.maven.plugin.issues.AbstractIssuesReportGenerator.sinkFigure(Abs=
> tractIssuesReportGenerator.java:142)
>        at
> org.apache.maven.plugin.issues.AbstractIssuesReportGenerator.sinkShowTypeIc=
> on(AbstractIssuesReportGenerator.java
>        at
> org.apache.maven.plugin.changes.ChangesReportGenerator.constructAction(Chan=
> gesReportGenerator.java:233)
>        at
> org.apache.maven.plugin.changes.ChangesReportGenerator.constructRelease(Cha=
> ngesReportGenerator.java:538)
>        at
> org.apache.maven.plugin.changes.ChangesReportGenerator.constructReleases(Ch=
> angesReportGenerator.java:495)
>        at
> org.apache.maven.plugin.changes.ChangesReportGenerator.doGenerateReport(Cha=
> ngesReportGenerator.java:217)
>        at
> org.apache.maven.plugin.changes.ChangesMojo.executeReport(ChangesMojo.java:=
> 321)
>        at
> org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport=
> .java:190)
>        at
> org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport=
> .java:144)
>        at
> org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(ReportD=
> ocumentRenderer.java:139)
>        at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(Defaul=
> tSiteRenderer.java:269)
>        at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteR=
> enderer.java:101)
>        at
> org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:133)
>        at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:100=
> )
>        at
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManag=
> er.java:490)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLif=
> ecycleExecutor.java:694)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycl=
> e(DefaultLifecycleExecutor.java:556)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLife=
> cycleExecutor.java:535)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFai=
> lures(DefaultLifecycleExecutor.java:3
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(Def=
> aultLifecycleExecutor.java:348)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycl=
> eExecutor.java:180)
>        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
>        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
>        at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
>        at
> org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
>        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>        at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:3=
> 9)
>        at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImp=
> l.java:25)
>        at java.lang.reflect.Method.invoke(Method.java:597)
>        at
> org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>        at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>        at
> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>        at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> 
> I use "mvn clean site" with:
> 
> Apache Maven *2.2.1* (r801777; 2009-08-06 15:16:01-0400)
> Java version: 1.6.0_31
> Java home: C:\Program Files\Java\jdk1.6.0_31\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7" version: "6.1" arch: "amd64" Family: "windows"
> 
> - The build with M3 works aside from that. The tests pass but they are not
> invoked with "mvn site". This is odd to me because in Commons, the build
> for site calls test. It makes sense to me to fail the site build if the
> test fails. But this build does not include the same reports as Commons and
> looks to be a different beast all together.
> 
> - For 2.0 we should have one build, Maven, and dump the Ant build file.
> 
> *Site Issues*
> 
> - Under "Release 1.2.17 - 2010-06-99", an entry is missing for
> https://issues.apache.org/bugzilla/show_bug.cgi?id=3D52913
> 
> - In issue-tracking.html, the first Item should not be an "Overview" that
> we say we use Bugzilla. The most important thing on this page is the link
> to the Log4J Bugzilla page.
>  I would just remove the "Overview" section, it adds no value and delays me
> getting to the information I need. If you want to keep it, make the last
> section under a different title.
> 
> - In license.html, the only section should be "The Apache Software License,
> Version 2.0", the stuff before it is just boilerplate noise.
> 
> - This is odd on the main page of the site, in plain text:
> 
> --- Apache log4j=E2=84=A2 --- --- ---
> 
> I do not get this when I download the tag and build.
> 
> - The Roadmap page has a similar problem (I do not get this when I download
> the tag and build.):
> 
> ------ Apache log4j 1.2 Roadmap ------ ------ ------
> 
> The road map should mention Log4J 2.0 and where is can be found and the
> state it is in at this time.
> 
> - Also (I do not get this when I download the tag and build.):
> 
> ------ log4j 1.2 Publications ------ ------ ------
> 
> - The Cross-reference Java source code looks weird because it points to
> pages instead of having links in the menu itself. I must be used to the
> Commons website generation! ;)
> 
> - For 2.0 I hope we can generate the same kind of reports we do for Commons
> like FindBugs, Clirr, PMD, Changes, and so on.
> 
> - For 2.0 I hope we adopt the standard Maven directory layout.
> 
> - The main Javadoc page shows some packages without package level
> documentation, which is kinda lame but not a show stopper.
> 
> Gary
> 
> 
> On Wed, May 2, 2012 at 1:29 AM, Christian Grobmeier <grobmeier@gmail.com> wrote:
> Hello,
> 
> please vote to release log4j 1.2.17.
> 
> Artifacts:
> http://people.apache.org/builds/logging/repo/log4j/log4j/
> 
> Tag:
> http://svn.apache.org/repos/asf/logging/log4j/tags/log4j-1.2.17/
> 
> Website:
> http://svn.apache.org/repos/asf/logging/site/trunk/docs/log4j/1.2/index.html
> 
> Please test carefully as this is my first log4j release.
> 
> [] +1, release the artifacts
> [] -1, don't release because
> 
> 
> The vote will remain open for the usual 72 hours.
> 
> Thanks,
> Christian
> 
> 
> 
> --
> http://www.grobmeier.de
> https://www.timeandbill.de
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
> 
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

Mime
View raw message