logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Appender<T extends Serializable> extends LifeCycle
Date Wed, 12 Dec 2012 00:36:53 GMT
Hi All:

I am wondering if the fact that Layout<T extends Serializable> and then
Appender<T extends Serializable> extends LifeCycle is really worth it, the
<T extends Serializable> part that is.

To cleanly push this all the way to all call sites will require a lot more
changes that are currently flagged as generics warnings.

Options:

1) Review the code and make that we use generics in Layout/Appender call
sites where needed, which is probably not many places. This means changing
code back to not using generics where Layout/Appender usages currently do.
This would also mean documenting the generic usage pattern, which still
does not take care of generics warnings.

2) Change Appender and Layout to not use generics: remove <T extends
Serializable>.

3) Push the change all the way through.

Thoughts?

I am starting to like 2).

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
View raw message