logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LOG4J2-273) Wasted work in XMLLayout.toSerializable()
Date Fri, 07 Jun 2013 15:38:21 GMT

     [ https://issues.apache.org/jira/browse/LOG4J2-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gary Gregory resolved LOG4J2-273.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0-beta8

{noformat}
commit -m "[LOG4J2-273] Wasted work in XMLLayout.toSerializable()." C:/svn/org/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/layout/XMLLayout.java
C:/svn/org/apache/log4j2/trunk/src/changes/changes.xml
    Sending        C:/svn/org/apache/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/layout/XMLLayout.java
    Sending        C:/svn/org/apache/log4j2/trunk/src/changes/changes.xml
    Transmitting file data ...
    Committed revision 1490688.
{noformat}
                
> Wasted work in XMLLayout.toSerializable()
> -----------------------------------------
>
>                 Key: LOG4J2-273
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-273
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Layouts
>    Affects Versions: 2.0-beta6
>         Environment: any
>            Reporter: Adrian Nistor
>            Assignee: Gary Gregory
>            Priority: Minor
>              Labels: patch, perfomance
>             Fix For: 2.0-beta8
>
>         Attachments: patch.diff
>
>
> The problem appears in Log4j 2.0-beta6 and in revision 1490297.  I
> attached a one-line patch that fixes it.
> In method "XMLLayout.toSerializable", the loop over
> "formats" should break immediately after
> "xmlSupported" is set to "true".  All the iterations after
> "xmlSupported" is set to "true" do not perform any useful work,
> at best they just set "xmlSupported" again to "true".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message