logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Nistor (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LOG4J2-297) Wasted work in TestConfigurator.testEnvironment
Date Sat, 29 Jun 2013 19:58:21 GMT
Adrian Nistor created LOG4J2-297:
------------------------------------

             Summary: Wasted work in TestConfigurator.testEnvironment
                 Key: LOG4J2-297
                 URL: https://issues.apache.org/jira/browse/LOG4J2-297
             Project: Log4j 2
          Issue Type: Bug
    Affects Versions: 2.0-beta7
         Environment: any
            Reporter: Adrian Nistor
         Attachments: patch.diff

The problem appears in Log4j 2.0-beta7 and in revision 1498014.  I
attached a one-line patch that fixes it.

In method "TestConfigurator.testEnvironment", the loop over
"map.entrySet()" should break immediately after "app" is set the first
time to "entry.getValue()".  I don't think "app" is set a second time
(and therefore all future iterations are not useful), but if it is,
then there is a problem in the implementation: when the loop exits,
"app" would be set to the last value of "entry.getValue()" that meets
some condition; however "map.entrySet()" is a Set and therefore the
order of iterating it is non-deterministic, i.e., the implementation
should not rely on what the "last value" is.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message