logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: org.apache.logging.log4j.core.config.plugins.PluginAttribute.required()
Date Wed, 09 Jul 2014 01:56:29 GMT
Hm... if the error logging takes place in the plugin framework, then it
should be removed from the create() methods, but then apps that do
programmatic configuration will not benefit from the error logging. We
would then need to either keep the current guard clauses (with no logging)
or remove the guard clauses and let the chips fall where they may with NPEs.

Thoughts?

Gary


On Mon, Jul 7, 2014 at 11:35 AM, Gary Gregory <garydgregory@gmail.com>
wrote:

> Why don't we have a required flag?
>
> Using it and throwing an Exception when this condition is violated would
> avoid guard code like:
>
>     @PluginFactory
>     public static RegexFilter createFilter(
>             @PluginAttribute("regex") final Pattern regex,
>             @PluginAttribute("useRawMsg") final Boolean useRawMsg,
>             @PluginAttribute("onMatch") final Result match,
>             @PluginAttribute("onMismatch") final Result mismatch) {
>
>         if (regex == null) {
>             LOGGER.error("A regular expression must be provided for
> RegexFilter");
>             return null;
>         }
>         return new RegexFilter(useRawMsg, regex, match, mismatch);
>     }
>
> ?
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
View raw message