logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Bridges (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LOG4J2-702) LoggerContext#waitForCompletion is not thread safe
Date Mon, 07 Jul 2014 04:31:34 GMT
Sean Bridges created LOG4J2-702:

             Summary: LoggerContext#waitForCompletion is not thread safe
                 Key: LOG4J2-702
                 URL: https://issues.apache.org/jira/browse/LOG4J2-702
             Project: Log4j 2
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.0-rc2
            Reporter: Sean Bridges

This is in trunk, svn commit 1608156

LoggerContext#waitForCompletion uses an AtomicInteger counter to try to detect if there are
any calls currently executing the log(Event) method, but it does not do so in a thread safe
manner.  Consider two threads A and B, where Thread A is calling clearAppenders(), and Thread
B is calling log(Event),

Thread A  loggerConfig.clearAppenders()
Thread A  loggerConfig.waitForCompletion()
Thread A  counter.get() //returns 0
Thread A  //loggerConfig.waitForCompletion() returns

Thread B  loggerConfig.log(Event)
Thread B  counter.increment()

Thread A  proceeds assuming no log calls are onging, but thread B is in the log method


I'm not sure what the requirements are, but if the requirement is to not lose logging events,
I think you need some sort of synchronization outside of the LoggerContext object.  

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

View raw message